Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 36 million developers.
Sign up
Popular repositories
518 contributions in the last year
Contribution activity
May 2019
birkenfeld has no activity
yet for this period.
April 2019
- birkenfeld/pyo3 Rust
Created a pull request in PyO3/pyo3 that received 15 comments
Make more constructors return &PyX instead of Py<PyX>
fixes #405 Remaining one is PyTuple, where I'm running into a test failure. Will provide as a separate PR.
+34
−35
•
15
comments
- Add advice for test and test-doc to Contributing.md
- Adjust the varargs/kwds objects to remove arguments consumed by parameters
- Allow omitting PyResult wrapping in property get/set methods
- Make PyTuple constructors return &PyTuple
- Make Py(Frozen)Set::new return PyResult<&Py(Frozen)Set>
- Make tons of small fixes in the guide
Created an issue in PyO3/pyo3 that received 3 comments
Should PySet::new return a PyResult?
Currently PySet::new can panic easily, since not all objects are hashable. I think it would make sense to return a PyResult here.
(For example, PyD…
3
comments