Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio History - Export to CSV Feature Request #2106

Open
dougbebber opened this issue Dec 11, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@dougbebber
Copy link

commented Dec 11, 2018

I’m looking to track my profit/loss trading and would like to see trading fees and security deposits added to the data available to be exported into a csv file.

This would add information regarding the cost-to-trade which would help tracking trade profit/loss.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Yes would be nice to improve the export features. Any dev up for it?

@dougbebber

This comment has been minimized.

Copy link
Author

commented Dec 14, 2018

Could we also include offer info in Portfolio History?

From a trade management perspective I think it makes sense to track orders (offers) as well as executed trades. Trades are the result of accepted offers. However, orders may be partially filled in a trade and tracking both orders and trades makes for a more comprehensive set of information for individual trade and money management.

I see that Offers have details that include an Offer ID, Creation date as well as details such as offer type, BTC amount, Min. BTC amount, Altcoin amount, security deposit,etc.

Trade details are also available. Being able to link trades to offers would help in trade management analysis. Questions like, how long did it take for my offer to be accepted in a trade.

What I would like to see is the data necessary to see how much value has been spent (including fees and deposits) along with how much value has been received. This would allow for the effective management of a traders P&L.

Please feel free to contact me as I would be more than willing to assist to make this happen.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Dec 23, 2018

Offer ID is same as trade ID. The only missing data (I assume, not verified by code now) is the offer amount and min. amount. The trade details shows the trade amount but not the offers original amount range. The data is there (trade contains the offer object), so should be trivial to add that to the UI and/or export data. Though we need to find a balance for how much data to display in the UI otherwise scrolling is required. The JSON data might be an option to show the full technical data for those who want to see all, without overloading the UI with details.
But agree that it would be good to show the relevant offer data. Maybe in the trade details there can be a button for the offer details, though might lead to popup hell :-).... Anyway any good UI solution is welcome as pull request!

But a maybe more interesting effort might be to work on a real P&L overview screen. Would require a bit of conceptual/UI design first but would be a nice feature to get a new screen where u see how successful the trades have been. Some charts there might be nices as well...

If you can make a proposal for such woudl be great. A wireframe layout would be enough. We don't have the dev resources atm to work on that, but if you can preovide a PR we would be happy to integrate. @ripcurlx can help with the app integration (adding tab in portfolio).

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Dec 23, 2018

And of couse such work is up for BSQ compensation requests!

@thedon-chris

This comment has been minimized.

Copy link

commented Feb 11, 2019

Is this feature complete, and is this issue still open for work?

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@thedon-chris This is up to be taken. If you want to work on it please contact @ManfredKarrer to add you as a contributor and I'll assign you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.