Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proposals are entered using correct URL #2473

Closed
devinbileck opened this issue Feb 27, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@devinbileck
Copy link
Member

commented Feb 27, 2019

URL redirects for proposals, compensation requests, and roles have been implemented by #2429. We now need to consider what approach (if any) to take with regards to entering proposal links within the UI to ensure people are using the correct URL.

If users don't use our redirected URLs, GitHub will be forever recorded in compensation requests and could potentially become dead links if we later relocate them elsewhere. This would be an issue if someone wants to view past proposals and attempts to follow the link to the proposal.

Likely the simplest approach is to only allow the user to enter the proposal id.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Likely the simplest approach is to only allow the user to enter the proposal id.

That would mix all proposals and comp. requests.

We could thought use diff. URLs for those types and use the ID.
More flexible maybe might be to use a warning popup in case the user uses a URL not matching the expected URL scheme.

@devinbileck

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

If the user only enters the id, the ui can assemble the full correct URL depending if it is a compensation request or proposal.
e.g.

https://bisq.network/proposals/<id>
https://bisq.network/compensation/<id>
@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

Yes. I am just not sure how strict or how flexible we should be here. At the end its just UI so we can change over time. I would prefer flexibility as that was my learnign over time that flexiblity is more important. But leave it to you, I can live with both approaches...

@devinbileck

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

I suppose another benefit of entering (and storing) just the id, is that we potentially can detect and flag duplicates and show a warning/error within the UI if that has already been reimbursed/approved.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

We would still need to allow to add a duplicate as it would otherwise be that a malicious user squatter a proposal.

@ManfredKarrer ManfredKarrer added this to the v0.9.7 milestone Mar 18, 2019

@ManfredKarrer ManfredKarrer removed this from the v0.9.7 milestone Apr 2, 2019

devinbileck added a commit to devinbileck/bisq that referenced this issue Apr 12, 2019

Add specific URL validation for proposal links
Since all proposals should be created in GitHub, and we have URL
redirects in place in case we switch platforms in the future, enforce
proposal links to utilize the specific URL redirect.

Resolves bisq-network#2473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.