Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting on proposal threw a NullPointerException #2627

Closed
ripcurlx opened this issue Apr 3, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

commented Apr 3, 2019

I wasn't able to reproduce it again, but somehow the selected Item was reset (maybe through an update in the background).

java.lang.NullPointerException
	at bisq.desktop.main.dao.governance.proposals.ProposalsView.onAccept(ProposalsView.java:432)
	at bisq.desktop.main.dao.governance.proposals.ProposalsView.lambda$showVoteOnProposalWindow$9(ProposalsView.java:343)
	at java.base/java.util.Optional.ifPresent(Optional.java:172)
	at bisq.desktop.main.overlays.windows.SelectProposalWindow.lambda$addContent$2(SelectProposalWindow.java:192)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
´´´

@ripcurlx ripcurlx self-assigned this Apr 3, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

I assume getBallotListItem() is null. Not sure how that can happen and how to deal with it. We shoudl set selectedItem @nullable and use it directly instead of getBallotListItem().

@ManfredKarrer ManfredKarrer added this to the v1.0.0 milestone Apr 3, 2019

@devinbileck

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

I just ran into this issue as well. Was voting in the proposal popup window. Had to close and reopen the popup to set my vote.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Do you know how to reproduce it?

@devinbileck

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

No. Just stumbled upon it once so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.