Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked up funds from a failed trade #2925

Open
dwknch opened this issue Jun 27, 2019 · 14 comments

Comments

Projects
None yet
5 participants
@dwknch
Copy link

commented Jun 27, 2019

See also issue #2924 reported just minutes ago.

This issue came with to pop-ups.

First pop-up is a warning about locked-up funds from a failed trade
Warning-locked-up-funds

Second pop-up is an error with java.lang.IllegalArgumentException. This one asks me to file an issue.
Error-illegal-argument

Finally I'm sending you the corresponding log file
bisq.log

Thanks

@dwknch

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

An additional problem that currently hinders proper use of the Bisq client on my side:
Every time I try to switch to the "open trades" tab under "portfolio" tab, I get the Error with java.lang.IllegalArgumentException (see other screenshot) and after closing the error screen it remains empty as in the following screenshot:
empty-open-trades

The little "2" on the portfolio tab seems to suggest that there are 2 open trades.
However none of "my open orders" has disappeared, which usually would happen after successful creation of a trade.

Anyone facing the same issue? How to get the situation unstuck?
Reinitialize the app with the seed phrase? Any suggestion welcome.

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Looking at the log file it's throwing the IllegalArgumentException due to the price of a trade being non positive. This is probably the failed trade so the problem will persist.

I can't think of a good way to handle this right now. Will have to come back on that.

@dwknch

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

sqrrm added a commit to sqrrm/bisq-desktop that referenced this issue Jun 27, 2019

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

If you're feeling adventurous you can try building from my PR at #2926. I haven't been able to test it since I couldn't reproduce your issue though, so it's completely untested. I don't think it could cause any harm though and it should avoid the IllegalArgumentException. You could also wait a bit to get some feedback from the other devs on this PR.

@dwknch

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

Thanks for the effort, but I don't feel that adventurous and don't have the time on my hands right now learning to build Bisq myself.
Good idea to wait and see what other devs might say.
Other question: since I'm not able to act from the pending trade tab, how will I be involved in the dispute that will inevitable come up in about 24 hours?

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

The dispute resolution should be ok as long as you don't open the details of the contract. Your trade history won't show after that but we should have a fix for this soon enough.

@a123b

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

I think this is actually a duplicate of #2235, which was closed without being fixed for whatever reason...

@geg780

This comment has been minimized.

Copy link

commented Jun 28, 2019

seems that the bisq client on the other side of the trade froze also when taking the trade.

@a123b

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

How do you know? I'd expect that the trade would fail with a timeout on the other side of the trade.

@geg780

This comment has been minimized.

Copy link

commented Jun 28, 2019

cause im the buyer and i managed to contact the seller with the revolut phone number associated to the trade. my bisq client froze, i had to reboot and the trade showed up.

@a123b

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Oh, I confused this issue with OP's other issue. If you are were having issues on the other side of this exact trade, it could be helpful if you upload your bisq.log file, too!

@UnityJon

This comment has been minimized.

Copy link

commented Jun 29, 2019

Had same issue as OP. returned to computer to get a bunch of popups. 1st one saying an attempt to take my offer was rejected because of price mismatch. Then one that buyer had initiated payment. Then one about funds locked up due to a failed trade. After which couldn't go to open offers or it would crash with the java error. Other party opened a dispute - and after arbitrator closed released all funds (I'd received payment and confirmed so) the error vanished and could trade again. Was unable to confirm the trade or initiate a dispute myself.

@a123b

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

@UnityJon Interesting. Can you see the problematic trade in the portfolio history tab? And if you can, is the listed price for the trade correct?

@UnityJon

This comment has been minimized.

Copy link

commented Jul 1, 2019

No, cant see the problematic trade - as now I get the java Nullpointer exception if I go to the history tab.

However, I do remember clearly that the mismatch error was that the seller offered to buy at about £9650/BTC when I was asking for £98xx. The arbitrator who handled the dispute told me the price in the successful trade which was 9789.617 - that matched the sort of rate I was expecting and the amount of BTC I was selling plus amount of fiat received (£1214).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.