Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: CreateMakerFeeTx #4336

Closed
sundaywar opened this issue Jun 25, 2020 · 2 comments · Fixed by #4345
Closed

Bug Report: CreateMakerFeeTx #4336

sundaywar opened this issue Jun 25, 2020 · 2 comments · Fixed by #4345

Comments

@sundaywar
Copy link

sundaywar commented Jun 25, 2020 •
edited

Description

Funding a transaction resulted in an error, screen capture & logs attached.

Version

1.3.5

Steps to reproduce

Expected behaviour

Fund transaction without errors

Actual behaviour

Fund transaction impossible

Screenshots


bisq error

Device or machine

macOS

Additional info

log file.log
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 25, 2020

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

@jmacxx
Copy link
Contributor

jmacxx commented Jun 25, 2020

Interpretation of log file events:

10:01:26 new offer is entered, fee is estimated @ 4160 bytes (16 sats/byte)
10:28:26 funds received from external source
10:30:31 offer is confirmed by user, fee is estimated @ 4680 bytes (18 sats/byte)
error pops up due to insufficient funds 520 sats missing
4680 - 4160 = 520 (missing amount).

Summary: fees rose in between making the offer and confirming it. Since funding was exact amount from an external wallet, the extra sats were not available to make the transaction.

Same issue raised by others in #4227, #4278.
PR #4266 was created over a month ago to solve this issue. ping @sqrrm / @ripcurlx

@jmacxx jmacxx mentioned this issue Jun 25, 2020
Closed
jmacxx added a commit to jmacxx/bisq that referenced this issue Jun 29, 2020
@jmacxx
Create order using the same tx fee specified at funding
f3fa5ad 
This fixes an issue whereby updates from the fee API were causing
Insufficient Funds exception. Since the wallet is funded with a
specific amount (deposit+trade fee+txFee), that same amount has
to be used when the user confirms offer creation (which could be
some time later).

Fixes bisq-network#4227
Fixes bisq-network#4278
Fixes bisq-network#4336
Fixes bisq-network#4327
@jmacxx jmacxx mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jmacxx @sundaywar