New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last request timestamp in price feed service #1730

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@devinbileck
Member

devinbileck commented Sep 27, 2018

I noticed the last update time shown in the market price popup was incorrect. It was updating/refreshing, but not accurate.
image

Upon debugging, I identified the timestamps were incorrectly being multiplied by 1000 in the price feed service. Removing this caused it to return the correct date, as shown below.
image

@ManfredKarrer

Ups we were ahead of time ;-) in year 50710. A bit too far ;-)

ACK.

@ManfredKarrer ManfredKarrer merged commit 91153c2 into bisq-network:master Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:Fix-last-update-timestamp-in-price-feed-service branch Sep 28, 2018

@devinbileck devinbileck referenced this pull request Sep 28, 2018

Closed

For September 2018 #133

@devinbileck devinbileck referenced this pull request Oct 30, 2018

Closed

For October 2018 #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment