New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #1735

Merged
merged 14 commits into from Sep 29, 2018

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Member

ManfredKarrer commented Sep 28, 2018

No description provided.

ManfredKarrer added some commits Sep 28, 2018

Update to btcd-cli4j 1763d7ef
- Fixes missing scriptType enum

@ManfredKarrer ManfredKarrer requested review from ripcurlx and sqrrm Sep 28, 2018

ManfredKarrer added some commits Sep 28, 2018

Remove remaining "N/A" in offer screen after price is set
- If the price is not available we display "N/A". Once the price
becomes available the listener handler was not removing the text (N/A).
Add comment for @ripcurlx to add some visual element
If we have multiple payment accounts we should show some info/warning to
make sure the user has selected the account he wants to use.
To use a popup is not recommended as we have already 3 popups at the
first time (if user has not clicked
don't show again).
@ripcurlx Maybe a similar warn triangle as used in create offer
might work?

See: #1733
Add buyers payment account name to trade screen
In case the buyer has setup multiple accounts for a payment method
we show the used payment account for that offer in the trade screen.

See: #1733

@ManfredKarrer ManfredKarrer changed the title from Fix missing scriptType for DAO to Fixes and improvements Sep 29, 2018

@sqrrm

sqrrm approved these changes Sep 29, 2018

utACK

I would prefer smaller more contextual PRs. That would make it easier to review.

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Sep 29, 2018

@sqrrm Yes agree. Was started with a small DAO only PR, but then added up more. Though to have several parallel branches where I need to cross merge until the PRs are merge in master is also a bit cumbersome. Some of the changes I needed immediately in my running dev tests (like the btcd-cli4j fixes). But sure I agree that is not as it should be....

@ManfredKarrer ManfredKarrer merged commit 6873d03 into bisq-network:master Sep 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment