New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferences view combobox selection #1774

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@devinbileck
Member

devinbileck commented Oct 14, 2018

Relates to #1771.

Regarding the ComboBoxes for adding currencies and altcoins in the preferences view:

  • Fix for using arrow keys to navigate the ComboBox adding the first option.
  • Fix prompt text no longer appearing after selecting an option.
  • Fix option not sorted when added back to the ComboBox.

devinbileck added some commits Oct 14, 2018

Fix combobox selection using arrow keys
Utilize the onHiding event rather than onAction event to prevent the
first option from being added when using arrow keys to navigate the
combobox. This will add the selected option when the combobox is
closing.
Fix prompt text disappearing after selection
After selecting an option from the combobox, it would no longer
display the prompt text and instead would be blank.

As per the documentation
https://docs.oracle.com/javase/10/docs/api/javafx/scene/control/ComboBoxBase.html#promptTextProperty:
> Prompt text is not displayed in all circumstances, it is dependent
> upon the subclasses of ComboBoxBase to clarify when promptText will be
> shown.

Therefore, use a custom buttonCell on the combo box to display the
prompt text.
Fix currency not sorted when added back to ComboBox
When removing a previously selected fiat or crypto currency, it was
adding it back to the bottom of the combobox rather than alphabetically.
So make sure to sort when adding a currency to the list.
@ripcurlx

This comment has been minimized.

Member

ripcurlx commented Oct 16, 2018

ACK - Thanks for the fix @devinbileck!

@ripcurlx ripcurlx merged commit ad5e232 into bisq-network:master Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-preferences-view-combobox-selection branch Oct 16, 2018

@devinbileck devinbileck referenced this pull request Oct 30, 2018

Closed

For October 2018 #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment