New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide text that is not applicable in take offer view #1775

Merged
merged 4 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@devinbileck
Member

devinbileck commented Oct 15, 2018

When taking an offer that does not specify an amount range, "Check if offer is available" text was being displayed when it shouldn't be.

It was explicitly hiding the offerAvailabilityBusyAnimation, but not the offerAvailabilityLabel.

Fixes #1742

devinbileck added some commits Oct 14, 2018

Hide text that is not applicable in take offer view
When taking an offer that does not specify an amount range, hide
the "Check if offer is available" text.

Fixes #1742
Move when offerAvailabilityBusyAnimation is stopped
Stop the offerAvailabilityBusyAnimation sooner, prior to showing
securityDepositInfo popup, when it is hiding related fields.
@ManfredKarrer

ManfredKarrer requested changes Oct 15, 2018 edited

NACK.
I added more background info in #1742. We must not hide is but change the layout so that it is better visible to the user and update the button states so that the user does not fund his wallet before the offer availibility check is successfully completed.

devinbileck added some commits Oct 16, 2018

@devinbileck

This comment has been minimized.

Member

devinbileck commented Oct 16, 2018

@ManfredKarrer A fixed amount offer now waits until the offer has been confirmed to be available, as shown below:
image

Once confirmed, it will show the fund trade fields:
image

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Oct 16, 2018

A cool! Looks good to me! @ripcurlx - What do you think? I leave it to you to review/merge.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx Oct 16, 2018

@ManfredKarrer

utACK - I would prefer if @ripcurlx does the review/merge

@ripcurlx

ACK - tested it on Regtest with a range and a single amount offer. Everything looking good!

@ripcurlx

This comment has been minimized.

Member

ripcurlx commented Oct 17, 2018

I'll merge it although Travis fails as it is related to the current Java 10 JDK not loaded issue.

@ripcurlx ripcurlx merged commit 9ce8b21 into bisq-network:master Oct 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@devinbileck devinbileck deleted the devinbileck:fix-take-offer-view branch Oct 17, 2018

@devinbileck devinbileck referenced this pull request Oct 30, 2018

Closed

For October 2018 #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment