New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PromptPay (Thailand) #1831

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@leshik
Contributor

leshik commented Oct 28, 2018

@ManfredKarrer

ACK

Thanks a lot for addint it! Dont forget to file a compensation request at https://github.com/bisq-network/compensation/issues

@@ -227,6 +229,9 @@ public PaymentMethod(String id, long maxTradePeriod, @NotNull Coin maxTradeLimit
ALI_PAY = new PaymentMethod(ALI_PAY_ID, DAY, maxTradeLimitLowRisk),
WECHAT_PAY = new PaymentMethod(WECHAT_PAY_ID, DAY, maxTradeLimitLowRisk),

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Oct 28, 2018

Member

Is that really a low risk payment method? Those are the ones where chargeback risk is super low or even stated that it is not possible to do chargeback. If so great, otherwise maybe better to use the mid risk parameter.

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Oct 28, 2018

Member

Ah I just read the comment in the issue. Seems its really low risk. So lets keep it.

@ManfredKarrer ManfredKarrer merged commit 8ab9c28 into bisq-network:master Oct 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Oct 29, 2018

@leshik Btw if you would be interested to work more on Bisq, please get in touch (Slack would be easiest)! We have plenty of open tasks, not all are in Github... If you are not familiar with the Bisq DAO please check out https://docs.bisq.network/dao/phase-zero.html . Partizipation in Bisq gets rewarded. If the DAO is too risky for you, lets talk there are other options as well...

@leshik

This comment has been minimized.

Contributor

leshik commented Oct 29, 2018

@ManfredKarrer oh thanks, I should learn more about DAO, will read & then join Slack.

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Oct 29, 2018

We are growing very fast now and we need more devs! So you are very welcome!

@leshik leshik referenced this pull request Oct 31, 2018

Closed

For October 2018 #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment