New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrc #1893

Merged
merged 7 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@freimair
Member

freimair commented Nov 7, 2018

Makes torrc "editable" via system properties.

Usage

  • use -Dtorrcfile=/path/to/torrc to source a valid torrc file from you system
  • use -Dtorrc:key1=value1 -Dtorrc:key2=value2 to append the tor configuration
  • use both for a more complex setup

Examples

  • use -Dtorrc:Socks5Proxy=host[:port] to configure a Socks5 proxy

  • use -Dtorrcfile=/path/to/customtorrc with customtorrc containing

    Log info file /tmp/bisq.tor.log
    TruncateLogFile 1
    

    to configure raw tor logging for troubleshooting.

Notes

note that torrc-entries which are critical to the software cannot be overwritten

bumps netlayer to 0.4.7 in order to profit from its bugfixes and addresses fixes #965, fixes #829 and thus fixes #413 and fixes #483

@freimair freimair requested review from cbeams and ManfredKarrer as code owners Nov 7, 2018

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Nov 7, 2018

Beside that nits in the comments looks good and I tested it with your example and it works. Very helpful or debugging tor issues to add that logs... At the user would need to change the log level to get full tor logging included.
Thanks for getting that implemented! Was often requested feature.

freimair added some commits Nov 7, 2018

@ManfredKarrer ManfredKarrer merged commit e8ead2d into bisq-network:master Nov 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment