New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize initial data load #1905

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Member

ManfredKarrer commented Nov 10, 2018

We changed the earlier behaviour with delayed execution of chunks of the list as it caused
worse results as if it is processed in one go.
Main reason is probably that listeners trigger more code and if that is called early at
startup we have better chances that the user has not already navigated to a screen where the
trade statistics are used for UI rendering.
We need to take care that the update period between releases stay short as with the current
situation before 0.9 release we receive 4000 objects with a newly installed client, which
causes the application to stay stuck for quite a while at startup.

ManfredKarrer added some commits Nov 10, 2018

Optimize processing of initial trade statistics and witness data
We changed the earlier behaviour with delayed execution of chunks of the list as it caused
worse results as if it is processed in one go.
Main reason is probably that listeners trigger more code and if that is called early at
startup we have better chances that the user has not already navigated to a screen where the
trade statistics are used for UI rendering.
We need to take care that the update period between releases stay short as with the current
situation before 0.9 release we receive 4000 objects with a newly installed client, which
causes the application to stay stuck for quite a while at startup.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx Nov 10, 2018

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Nov 10, 2018

@ripcurlx I was wondering if we should shoot out a quick new release based on the old release but with the actual trade statistic and witness data. I tested with new data directory and at first startup the app get frozen. After that it works, but pretty bad user experience... Surprised that we did not get more complaints... Do you think a new release could be done without a lot of effort (do you have still the old java setup on the VMs)?

@cbeams

This comment has been minimized.

Member

cbeams commented Nov 10, 2018

Glad you brought this up, @ManfredKarrer. I too have experienced this delay on starting up new instances. I meant to report it earlier myself. A must-fix, IMO. The delay is long enough that many if not most users would think something is fatally wrong with their client.

@ripcurlx

This comment has been minimized.

Member

ripcurlx commented Nov 10, 2018

@ManfredKarrer I have installed a new SDK, but I should have the old configured one still in the VM. I could create a 0.8.1 release on Monday based on the last tag and just update the store dbs.

@ripcurlx

This comment has been minimized.

Member

ripcurlx commented Nov 10, 2018

We could do it without sending out update messages and so on. Just to have a version for download that doesn't freezes that long on start-up until we have fixed this issue properly.

@ManfredKarrer

This comment has been minimized.

Member

ManfredKarrer commented Nov 10, 2018

@ripcurlx Yes would be great!
Only the TradeStatistics2Store_BTC_MAINNET and AccountAgeWitnessStore_BTC_MAINNET need to be updated with the a file from a live version.
And yes just make a silent update without sending a notification.

@ripcurlx

utACK

@ripcurlx ripcurlx merged commit 17a9d79 into bisq-network:master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:optimize-initial-data-load branch Nov 17, 2018

@ripcurlx ripcurlx referenced this pull request Nov 30, 2018

Closed

For November 2018 #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment