New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with wrong base currency #1913

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Member

ManfredKarrer commented Nov 11, 2018

From the changes in isCryptoCurrency which return true in case of BTC
there have been some bugs. We changed the check to distinguish between
altcoin and fiat to check for BTC as base currency now.
That area would require a bigger refactoring...

Fixes #1909

Fix issues with wrong base currency
From the changes in isCryptoCurrency which return true in case of BTC
there have been some bugs. We changed the check to distinguish between
altcoin and fiat to check for BTC as base currency now.
That area would require a bigger refactoring...

@ManfredKarrer ManfredKarrer requested review from ripcurlx, cbeams and sqrrm Nov 11, 2018

@cbeams

cbeams approved these changes Nov 12, 2018

ACK. I've just tested this locally and currency pairs are being reported as expected once again.

@ManfredKarrer ManfredKarrer merged commit fd6e7c8 into bisq-network:master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:fix-currency-bug branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment