diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java index f7f8b933bf2..cb4cd8430b4 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java @@ -213,7 +213,7 @@ public void addFormForDisplayAccount() { addCompactTopLabelTextField(gridPane, ++gridRow, BankUtil.getAccountTypeLabel(countryCode), bankAccountPayload.getAccountType()).second.setMouseTransparent(false); - addLimitations(); + addLimitations(true); } @Override @@ -275,7 +275,7 @@ public void addFormForAddAccount() { } }); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); updateFromInputs(); diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashAppForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashAppForm.java index a17906ec6e4..de4e8dd874c 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashAppForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashAppForm.java @@ -70,7 +70,7 @@ public void addFormForAddAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; FormBuilder.addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -89,7 +89,7 @@ public void addFormForDisplayAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; FormBuilder.addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java index 2adcd0bc594..ace51f1dfbb 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java @@ -243,7 +243,7 @@ public void addFormForDisplayAccount() { textArea.setText(requirements); } - addLimitations(); + addLimitations(true); } @Override @@ -310,7 +310,7 @@ public void addFormForAddAccount() { updateFromInputs(); }); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); updateFromInputs(); diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java index 00f38c69f6b..291358e60bd 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java @@ -81,7 +81,7 @@ public void addFormForAddAccount() { TradeCurrency singleTradeCurrency = chaseQuickPayAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -105,7 +105,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = chaseQuickPayAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java index cc2f5c67304..9ecde3e17e2 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java @@ -81,7 +81,7 @@ public void addFormForAddAccount() { final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -106,7 +106,7 @@ public void addFormForDisplayAccount() { final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CryptoCurrencyForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CryptoCurrencyForm.java index b7292b6a640..a0dd1c54738 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/CryptoCurrencyForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/CryptoCurrencyForm.java @@ -99,7 +99,7 @@ public void addFormForAddAccount() { updateFromInputs(); }); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -138,7 +138,7 @@ public void addFormForDisplayAccount() { final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.altcoin"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java index 111bae19880..5ead5ebc66d 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java @@ -118,7 +118,7 @@ public void addFormForAddAccount() { updateFromInputs(); }); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -168,7 +168,7 @@ public void addFormForDisplayAccount() { textArea.setPrefHeight(60); textArea.setEditable(false); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java index ba8f48b3f03..cdeb6aaceb5 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java @@ -86,7 +86,7 @@ public void addFormForAddAccount() { String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -110,7 +110,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = fasterPaymentsAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java index 06fa941ff4d..b32d0704b31 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java @@ -39,7 +39,7 @@ public void addFormForAddAccount() { addTradeCurrency(); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -83,6 +83,6 @@ private void addFormForAccountNumberDisplayAccount(String accountName, PaymentMe final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } } diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java index ba02fec4bbb..1fb08de78ce 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java @@ -72,7 +72,7 @@ public void addFormForAddAccount() { TradeCurrency singleTradeCurrency = halCashAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -94,7 +94,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = halCashAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java index d335548a38f..ffe20fccb4d 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java @@ -99,7 +99,7 @@ public void addFormForAddAccount() { String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -127,7 +127,7 @@ public void addFormForDisplayAccount() { String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java index b45d177974f..39e741f2bc5 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java @@ -69,7 +69,7 @@ public void addFormForAddAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -88,7 +88,7 @@ public void addFormForDisplayAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java index e4034536abd..a6e0a2c2c21 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java @@ -96,7 +96,7 @@ public void addFormForDisplayAccount() { moneyGramAccountPayload.getState()).second.setMouseTransparent(false); addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.email"), moneyGramAccountPayload.getEmail()); - addLimitations(); + addLimitations(true); addCurrenciesGrid(false); } @@ -130,7 +130,7 @@ public void addFormForAddAccount() { emailInputTextField.setValidator(emailValidator); addCurrenciesGrid(true); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); updateFromInputs(); diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/OKPayForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/OKPayForm.java index 417713addf3..8e1a74e9d49 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/OKPayForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/OKPayForm.java @@ -83,7 +83,7 @@ public void addFormForAddAccount() { }); addCurrenciesGrid(true); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -128,7 +128,7 @@ public void addFormForDisplayAccount() { TextField field = FormBuilder.addTopLabelTextField(gridPane, ++gridRow, Res.get("payment.wallet"), okPayAccount.getAccountNr()).second; field.setMouseTransparent(false); - addLimitations(); + addLimitations(true); addCurrenciesGrid(false); } diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java index bde1413b3ab..08efe3f194e 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java @@ -76,8 +76,8 @@ public abstract class PaymentMethodForm { protected final BooleanProperty allInputsValid = new SimpleBooleanProperty(); protected int gridRowFrom; - protected InputTextField accountNameTextField; - protected ToggleButton useCustomAccountNameToggleButton; + InputTextField accountNameTextField; + ToggleButton useCustomAccountNameToggleButton; protected ComboBox currencyComboBox; public PaymentMethodForm(PaymentAccount paymentAccount, AccountAgeWitnessService accountAgeWitnessService, @@ -155,7 +155,7 @@ else if (hours > 24) return time; } - protected void addLimitations() { + protected void addLimitations(boolean isDisplayForm) { long hours = paymentAccount.getPaymentMethod().getMaxTradePeriod() / 3600_000; final TradeCurrency tradeCurrency; @@ -183,7 +183,11 @@ else if (!paymentAccount.getTradeCurrencies().isEmpty()) getTimeText(hours), formatter.formatCoinWithCode(Coin.valueOf(accountAgeWitnessService.getMyTradeLimit(paymentAccount, tradeCurrency.getCode()))), formatter.formatAccountAge(accountAge)); - addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.limitations"), limitationsText); + + if (isDisplayForm) + addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.limitations"), limitationsText); + else + addTopLabelTextField(gridPane, ++gridRow, Res.get("payment.limitations"), limitationsText); if (isAddAccountScreen) { InputTextField inputTextField = addInputTextField(gridPane, ++gridRow, Res.get("payment.salt"), 0); diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java index f98e5905ed9..a5c629e91ac 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java @@ -79,7 +79,7 @@ public void addFormForAddAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -100,7 +100,7 @@ public void addFormForDisplayAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java index 5960a23d36e..7ddeb92d145 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java @@ -72,7 +72,7 @@ public void addFormForAddAccount() { TradeCurrency singleTradeCurrency = promptPayAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -94,7 +94,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = promptPayAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java index 4386b4a148f..df6fc0acd1c 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java @@ -73,7 +73,7 @@ public void addFormForAddAccount() { }); addCurrenciesGrid(true); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -105,7 +105,7 @@ public void addFormForDisplayAccount() { TextField field = addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.revolut.accountId"), account.getAccountId()).second; field.setMouseTransparent(false); - addLimitations(); + addLimitations(true); addCurrenciesGrid(false); } diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java index 6f535f2465e..f8011489740 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java @@ -115,7 +115,7 @@ public void addFormForAddAccount() { addEuroCountriesGrid(); addNonEuroCountriesGrid(); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); countryComboBox.setItems(FXCollections.observableArrayList(CountryUtil.getAllSepaCountries())); @@ -207,7 +207,7 @@ public void addFormForDisplayAccount() { acceptedCountries.setMouseTransparent(false); acceptedCountries.setTooltip(tooltip); } - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java index 347b127e4ca..f2867f26156 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java @@ -115,7 +115,7 @@ public void addFormForAddAccount() { addEuroCountriesGrid(); addNonEuroCountriesGrid(); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); countryComboBox.setItems(FXCollections.observableArrayList(CountryUtil.getAllSepaInstantCountries())); @@ -206,7 +206,7 @@ public void addFormForDisplayAccount() { acceptedCountries.setMouseTransparent(false); acceptedCountries.setTooltip(tooltip); } - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java index 61f689cb714..4a64ef75890 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java @@ -87,7 +87,7 @@ public void addFormForAddAccount() { TradeCurrency singleTradeCurrency = swishAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -111,7 +111,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = swishAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java index c22c43253d1..41420a63688 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java @@ -88,7 +88,7 @@ public void addFormForAddAccount() { String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -113,7 +113,7 @@ public void addFormForDisplayAccount() { TradeCurrency singleTradeCurrency = usPostalMoneyOrderAccount.getSingleTradeCurrency(); String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : "null"; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java index ffc2e7e4a9f..2ee6dae511f 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java @@ -72,7 +72,7 @@ public void addFormForAddAccount() { }); addCurrenciesGrid(true); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -105,7 +105,7 @@ public void addFormForDisplayAccount() { TextField field = addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.uphold.accountId"), upholdAccount.getAccountId()).second; field.setMouseTransparent(false); - addLimitations(); + addLimitations(true); addCurrenciesGrid(false); } diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/VenmoForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/VenmoForm.java index 4d2b8d7d1f6..80f60ce412f 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/VenmoForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/VenmoForm.java @@ -83,7 +83,7 @@ public void addFormForAddAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); } @@ -109,7 +109,7 @@ public void addFormForDisplayAccount() { final TradeCurrency singleTradeCurrency = account.getSingleTradeCurrency(); final String nameAndCode = singleTradeCurrency != null ? singleTradeCurrency.getNameAndCode() : ""; addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("shared.currency"), nameAndCode); - addLimitations(); + addLimitations(true); } @Override diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java index 8b048b8b02e..296262aaa0e 100644 --- a/desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java +++ b/desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java @@ -105,7 +105,7 @@ public void addFormForDisplayAccount() { westernUnionAccountPayload.getState()).second.setMouseTransparent(false); addCompactTopLabelTextField(gridPane, ++gridRow, Res.get("payment.email"), westernUnionAccountPayload.getEmail()); - addLimitations(); + addLimitations(true); } private void onTradeCurrencySelected(TradeCurrency tradeCurrency) { @@ -167,7 +167,7 @@ public void addFormForAddAccount() { }); emailInputTextField.setValidator(emailValidator); - addLimitations(); + addLimitations(false); addAccountNameTextFieldWithAutoFillToggleButton(); updateFromInputs(); diff --git a/desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java b/desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java index 89849fc452e..c3993e4d43f 100644 --- a/desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java +++ b/desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java @@ -71,6 +71,7 @@ import javafx.beans.value.ChangeListener; import javafx.collections.FXCollections; +import javafx.collections.SetChangeListener; import javafx.util.StringConverter; @@ -104,6 +105,7 @@ public class MobileNotificationsView extends ActivatableView { priceCheckBoxListener, priceAlertHighFocusListener, priceAlertLowFocusListener, marketAlertTriggerFocusListener; private ChangeListener tokenInputTextFieldListener, priceAlertHighListener, priceAlertLowListener, marketAlertTriggerListener; private ChangeListener priceFeedServiceListener; + private SetChangeListener paymentAccountsChangeListener; private int gridRow = 0; private int testMsgCounter = 0; @@ -135,6 +137,7 @@ private MobileNotificationsView(Preferences preferences, @Override public void initialize() { + createListeners(); createSetupFields(); createSettingsFields(); createMarketAlertFields(); @@ -143,6 +146,8 @@ public void initialize() { @Override protected void activate() { + addListeners(); + // setup tokenInputTextField.textProperty().addListener(tokenInputTextFieldListener); downloadButton.setOnAction(e -> onDownload()); @@ -165,7 +170,7 @@ protected void activate() { addMarketAlertButton.setOnAction(e -> onAddMarketAlert()); manageAlertsButton.setOnAction(e -> onManageMarketAlerts()); - paymentAccountsComboBox.setItems(FXCollections.observableArrayList(user.getPaymentAccountsAsObservable())); + fillPaymentAccounts(); // price alert priceAlertHighInputTextField.textProperty().addListener(priceAlertHighListener); @@ -195,6 +200,8 @@ protected void activate() { @Override protected void deactivate() { + removeListeners(); + // setup tokenInputTextField.textProperty().removeListener(tokenInputTextFieldListener); downloadButton.setOnAction(null); @@ -774,5 +781,23 @@ private void applyPriceFormatting(InputTextField inputTextField) { updatePriceAlertFields(); } } + + private void createListeners() { + paymentAccountsChangeListener = change -> fillPaymentAccounts(); + } + + private void addListeners() { + user.getPaymentAccountsAsObservable().addListener(paymentAccountsChangeListener); + } + + + private void removeListeners() { + user.getPaymentAccountsAsObservable().removeListener(paymentAccountsChangeListener); + } + + private void fillPaymentAccounts() { + paymentAccountsComboBox.setItems(FXCollections.observableArrayList(user.getPaymentAccounts())); + } + } diff --git a/desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java b/desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java index 930e586d386..73cc8232682 100644 --- a/desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java +++ b/desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java @@ -368,8 +368,11 @@ public void initWithData(Offer offer) { paymentMethodTextField.setManaged(!showComboBox); paymentMethodLabel.setVisible(!showComboBox); paymentMethodLabel.setManaged(!showComboBox); - if (!showComboBox) - paymentMethodTextField.setText(Res.get(model.getPaymentMethod().getId())); + + if (!showComboBox) { + paymentMethodTextField.setText(model.getPossiblePaymentAccounts().get(0).getAccountName()); + } + currencyTextField.setText(model.dataModel.getCurrencyNameAndCode()); amountDescriptionLabel.setText(model.getAmountDescription());