New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left align columns, except last one #2062

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

ripcurlx commented Dec 5, 2018

Adapted the left align style for all columns except the last one based on the design of @pedromvpg. I saw that for avatars and icons that are in the last column they were centered, so I implemented it like that. @pedromvpg Could you please have a look if it is as you wanted it to have?

Maybe we could discuss in this PR also the line height of rows in certain screens. It came up during the release that some are not very happy with the line height as it will show less information now than it did before.

The question is f the user has the requirement to get everything in one screen or if the extended height of the rows is more pleasant to watch.

As this is an design issue @pedromvpg has the last call, but it seems there should be some public discussion on this.

bildschirmfoto 2018-12-05 um 14 45 02

bildschirmfoto 2018-12-05 um 14 44 58

bildschirmfoto 2018-12-05 um 14 44 50

bildschirmfoto 2018-12-05 um 14 43 36

bildschirmfoto 2018-12-05 um 14 43 32

bildschirmfoto 2018-12-05 um 14 43 27

bildschirmfoto 2018-12-05 um 14 42 49

bildschirmfoto 2018-12-05 um 14 41 36

bildschirmfoto 2018-12-05 um 14 36 09

bildschirmfoto 2018-12-05 um 14 36 01

ripcurlx added some commits Dec 5, 2018

Left align all columns, except last one (right-aligned)
Last columns with avatars or icons are centered
Use IBM Sans in columns

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Dec 5, 2018

@ripcurlx ripcurlx requested a review from pedromvpg Dec 5, 2018

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Dec 5, 2018

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Dec 5, 2018

I think those colums with buttons (Select) or checkboxes should be centered still or the header alignment aligned with the button text.
In the first screen there is still one centered.
The confirmation column could be centered as well IMO.
Those with the info icon on the right might be more clean if that is right aligned.

But no strong opinions here...

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 806fcbe into bisq-network:master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Dec 30, 2018

Closed

For December 2018 #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment