New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only first block in pendingBlocks instead of iteration #2067

Merged
merged 3 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Dec 5, 2018

Do not merge yet as more will be added.

@sqrrm Just added that PR for sharing progress on improvements. Needs more testings, but would be good if you could base your testing on that PR.

@ManfredKarrer ManfredKarrer requested a review from sqrrm Dec 5, 2018

ManfredKarrer added some commits Dec 7, 2018

@ManfredKarrer ManfredKarrer changed the title [WIP] Use only first block in pendingBlocks instead of iteration Use only first block in pendingBlocks instead of iteration Dec 7, 2018

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Dec 7, 2018

I will merge that now as I detected a problem in the current master which this PR should avoid.

@ManfredKarrer ManfredKarrer merged commit 3cbf994 into bisq-network:master Dec 7, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:DAO_improve-reorg-handling branch Dec 8, 2018

@sqrrm

This comment has been minimized.

Copy link
Member

sqrrm commented Dec 8, 2018

Sorry for slow review.

This looks much better but it still breaks the phase handling. I don't see the big recursions in the log, naturally, so clearly better than before.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Dec 8, 2018

Yes I have not looked into the phases yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment