New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't validate display fields in proposal display #2074

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@sqrrm
Copy link
Member

sqrrm commented Dec 6, 2018

When displaying fields they shouldn't run validation as they're non-editable and populated from external data.

@sqrrm sqrrm requested review from ManfredKarrer and ripcurlx as code owners Dec 6, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit aadfd5c into bisq-network:master Dec 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sqrrm sqrrm referenced this pull request Dec 29, 2018

Closed

For December 2018 #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment