New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surgical fix to default command line parameters #2090

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@freimair
Copy link
Member

freimair commented Dec 7, 2018

This request fixes #2084 similar to the fix introduced by @cbeams in #2063 (which addressed #2048).

This should get rid of all side-effects we encountered by providing the defaults in the JOptSimple parser already. Since #1961 did not remove any code concerning the "old" default handling this fix should be production ready.

However, as @cbeams mentioned in #1961, he has further changes regarding the command line argument parsing queued up. So git revert e9ca340 (this commit) and git revert b122ff4 should prepare Bisq for your queued changes again.

@freimair freimair requested a review from ManfredKarrer as a code owner Dec 7, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

ACK

@ManfredKarrer ManfredKarrer merged commit fd2d2fd into bisq-network:master Dec 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cbeams

This comment has been minimized.

Copy link
Member

cbeams commented Dec 10, 2018

utACK. Thanks, @freimair.

@freimair freimair deleted the freimair:remove-defaults branch Dec 10, 2018

@freimair freimair referenced this pull request Dec 28, 2018

Closed

For December 2018 #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment