New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the changed vote for 10 seconds #2099

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
2 participants
@sqrrm
Copy link
Member

sqrrm commented Dec 9, 2018

No description provided.

@sqrrm sqrrm requested review from ManfredKarrer and ripcurlx as code owners Dec 9, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 7f6aa8f into bisq-network:master Dec 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ManfredKarrer added a commit that referenced this pull request Dec 9, 2018

Revert #2099
Sorry was too fast with an untested ACK and merge.

- The icon loses it's color so its always black now. I think we should
stick with the colors.
- The duration was set to 10 seconds. I thinks that is too long.
- Not clear what the 'Object a = new Object() {{' definition means. I
assume you want a initializer block instead
('{ itemProperty().addListener.... }')
- We should maybe better make a small component out of that button
which behaves similar like the checkbox or radio button animation.
Maybe we can use those components instead of a normal button.
Or maybe the normal button animation from the new UI framework is enough.

@BravoIndia BravoIndia referenced this pull request Dec 30, 2018

Closed

For December 2018 #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment