New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine various ui strings #2104

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@m52go
Copy link
Member

m52go commented Dec 10, 2018

When I installed a fresh copy of Bisq to test the DAO, some of the text in the UI looked like it could use some edits.

This PR includes edits to a variety of text, beyond what I saw, but I only made significant changes (e.g., adding a line break) to elements that I came across myself which I knew for sure could handle them.

There were a couple places I wanted to add a new line break, but wasn't sure if the UI could handle it, so I passed (in order to avoid creating any other issues).

@m52go m52go requested a review from ManfredKarrer as a code owner Dec 10, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

Maybe you can push another small change to that issue with "support" as mentioned?

@@ -807,26 +807,26 @@ support.buyerOfferer=BTC buyer/Maker
support.sellerOfferer=BTC seller/Maker
support.buyerTaker=BTC buyer/Taker
support.sellerTaker=BTC seller/Taker
support.backgroundInfo=Bisq is not a company and does not provide any kind of customer support.\n\n\
support.backgroundInfo=Bisq is not a company and does not guarantee customer support.\n\n\

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Dec 10, 2018

Member

Maybe we can rewrite that. It sounds a bit harsh to say there is no support. In fact our support is better than in many companies. its just nto company provided but community driven....

This comment has been minimized.

@m52go

m52go Dec 10, 2018

Member

Ha yes, I thought the same thing, but assumed it was on purpose for legal reasons so I didn't change it. Pushing an update now.

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit b3091a3 into bisq-network:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Dec 30, 2018

Closed

For December 2018 #195

@m52go m52go referenced this pull request Jan 1, 2019

Closed

For December 2018 #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment