New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor DAO ui fixes #2109

Merged
merged 4 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

ripcurlx commented Dec 11, 2018

No description provided.

ripcurlx added some commits Dec 11, 2018

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Dec 11, 2018

@sqrrm
Copy link
Member

sqrrm left a comment

NACK

Need to change all labels to upper case

@@ -58,7 +58,7 @@ public MenuItem(Navigation navigation,
this.viewClass = viewClass;
this.baseNavPath = baseNavPath;

setLabelText(title);
setLabelText(title.toUpperCase());

This comment has been minimized.

@sqrrm

sqrrm Dec 11, 2018

Member

This doesn't handle the 'Vote on proposals'/'Browse open proposals' text that changes depending on phase

This comment has been minimized.

@sqrrm

sqrrm Dec 11, 2018

Member

Could be fixed in GovernanceView.java:90/92

This comment has been minimized.

@ripcurlx

ripcurlx Dec 11, 2018

Member

Thanks for pointing it out. Just fixed it by converting to uppercase also on label update.

This comment has been minimized.

@ripcurlx

ripcurlx Dec 11, 2018

Member

And I removed now an unnecessary uppercasing. Should have looked through the code more carefully 🙄

This comment has been minimized.

@sqrrm

sqrrm Dec 11, 2018

Member

Yes, better to only set it inside setLabelText as you do now

ripcurlx added some commits Dec 11, 2018

@sqrrm

sqrrm approved these changes Dec 11, 2018

Copy link
Member

sqrrm left a comment

ACK

Of course, much better to handle it there :)

@ManfredKarrer ManfredKarrer merged commit f0025a4 into bisq-network:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sqrrm sqrrm referenced this pull request Dec 29, 2018

Closed

For December 2018 #190

@ripcurlx ripcurlx referenced this pull request Dec 30, 2018

Closed

For December 2018 #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment