New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install_java.bat when setting long PATH environment variable #2131

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

devinbileck commented Dec 15, 2018

Avoid using setx to append to the PATH environment variable as it will
truncate to 1024 characters. Instead, use SetEnvironmentVariable
in powershell.

Fix when setting long PATH environment variable
Avoid using setx to append to the PATH environment variable as it will
truncate to 1024 characters. Instead, use SetEnvironmentVariable
in powershell.

@devinbileck devinbileck requested a review from ManfredKarrer as a code owner Dec 15, 2018

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 5a8731c into bisq-network:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-install_java.bat branch Dec 15, 2018

@devinbileck devinbileck referenced this pull request Dec 29, 2018

Closed

For December 2018 #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment