New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows install experience #2164

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

devinbileck commented Dec 22, 2018

  • Increase the minimum supported OS version to Windows 7 with SP1.
    Previously it was Windows XP which has been EOL for some time now.
    Hopefully no one is still using Windows XP.

  • Show a final dialog once the install has completed. This will inform
    the user that the install has completed with an option to launch the
    application. Previously it would skip this final dialog and immediately
    launch the application, but the user may not want to launch it
    immediately.

  • Create an application shortcut on the user's desktop.

  • Check if the application is running prior to install or uninstall and
    abort with a prompt to the user that the application must first be
    closed.

  • German, French, and Spanish translations. The installer should
    auto-detect the OS language and display all text in the appropriate
    language. For now I have just added a couple languages, but it is very
    easy to add any of the other languages supported by Inno Setup.

  • Additionally, I removed a few unnecessary items that weren't being
    utilized such as installing a service.

Update windows install experience
- Increase the minimum supported OS version to Windows 7 with SP1.
Previously it was Windows XP which has been EOL for some time now.
Hopefully no one is still using Windows XP.

- Show a final dialog once the install has completed. This will inform
the user that the install has completed with an option to launch the
application. Previously it would skip this final dialog and immediately
launch the application, but the user may not want to launch it
immediately.

- Create an application shortcut on the user's desktop.

- Check if the application is running prior to install or uninstall and
abort with a prompt to the user that the application must first be
closed.

- German, French, and Spanish translations. The installer should
auto-detect the OS language and display all text in the appropriate
language. For now I have just added a couple languages, but it is very
easy to add any of the other languages supported by Inno Setup.

- Additionally, I removed a few unnecessary items that weren't being
utilized such as installing a service.

@devinbileck devinbileck referenced this pull request Dec 29, 2018

Closed

For December 2018 #187

@ManfredKarrer ManfredKarrer removed their request for review Jan 1, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK - Thanks, looking good! I'll give everything an in-depth testing round during our next release on Tuesday.

@ripcurlx ripcurlx merged commit d1a5aae into bisq-network:master Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:update_windows_install_experience branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment