New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisq Network Monitor: Babysteps #2181

Merged
merged 45 commits into from Dec 30, 2018

Conversation

Projects
None yet
3 participants
@freimair
Copy link
Member

freimair commented Dec 28, 2018

Babysteps release of the Bisq Network Monitor proposed here

@freimair freimair requested a review from cbeams as a code owner Dec 28, 2018

@freimair freimair requested a review from ManfredKarrer as a code owner Dec 28, 2018

@freimair freimair referenced this pull request Dec 28, 2018

Closed

For December 2018 #185

@cbeams
Copy link
Member

cbeams left a comment

This was a very quick review from my side. Mostly style nits, but my question about the removal of gradle-witness data should be addressed before approval.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Dec 29, 2018

Will review once back from holiday in January.

freimair added some commits Dec 29, 2018

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Dec 29, 2018

Is bisq.monitor.metric.Dummy.java still needed (not used yet)?

freimair and others added some commits Dec 29, 2018

Add monitor directory as parent for test directories
- Apply reorg imports and reformat to test classes
Update gitignore
- Add /monitor/TorHiddenServiceStartupTimeTests/* and
/monitor/monitor-tor/*
Apply code inspection
- Fix spelling
- Remove exception throw clause which was never thrown
- Add not null preconditions
- Remove unneeded types in diamonds
- Add final
- Fix java doc
- Make Reporter constructor protected (abstract)
Use 1.1.10 instead of $logbackVersion
$logbackVersion causes build errors.
Ignore tests
- Revert spelling error as misspelling was used for test
- Add TODO for failing test (timing issue, seems to fail just sometimes)
- Set @disable to test classes which take longer as Tor is started
@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

ACK

@ManfredKarrer ManfredKarrer merged commit d013e7d into bisq-network:master Dec 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment