New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus color of buttons should be more saturated/darker (Issue #2134) #2187

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@CaveSpectre11
Copy link
Member

CaveSpectre11 commented Dec 31, 2018

Issue #2134 reports an issue with hovering or tabbing focus onto a button lightens the button rather than darkens it, making it more apt to appear disabled.

This PR corrects this behavior by changing the derived color on hover and focused to -30% rather than +30%.

One potential remaining issue is the action that occurs when the button is focused upon tabbing; there is an animated effect that dims the button. While it is now darker than previous, it still becomes somewhat washed out and not as vivid as a mouse hover.

@CaveSpectre11

This comment has been minimized.

Copy link
Member

CaveSpectre11 commented Dec 31, 2018

Hover (right side is hovered):
screenshot from 2018-12-31 12-40-10

screenshot from 2018-12-31 12-40-45

Focused (right side is focused)
screenshot from 2018-12-31 12-45-06

screenshot from 2018-12-31 12-44-28

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Jan 1, 2019

@ripcurlx Leave it to you. Maybe @pedromvpg could add his opinion as well!

@ManfredKarrer ManfredKarrer removed their request for review Jan 1, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK from a code perspective, but I'd love to get an ACK from @pedromvpg as well, if he's fine with these UI changes.

@ripcurlx ripcurlx requested a review from pedromvpg Jan 3, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 7, 2019

ACK - just tested it locally. @pedromvpg If you want to change the color/saturation, we can adapt it in the next release again.

@ripcurlx ripcurlx merged commit c985bf6 into bisq-network:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment