New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux packaging process #2190

Merged
merged 7 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@devinbileck
Copy link
Member

devinbileck commented Jan 3, 2019

The 64bitBuild.sh script has been renamed to package.sh and has
been updated so that it is capable of performing the complete packaging
process without having to rely on the jar first being built and prepped
from the MacOS scripts. However, it does support having the jar
previously built and prepped and will look for a prepped jar in the
desktop/package folder. If not found, it will build and prep it
prior to packaging.

Additionally, the Bruntime option passed to javapackager is unnecessary and
has been removed. The Bruntime option is valid only when the -native
option is set to jnlp.

Also, the prepare-system.sh script was removed as it did not appear to be
doing anything useful.

Finally, a release.sh script has been added that will perform the
release process of copying necessary files to a versioned release folder
and generating/verifying signatures. Windows and MacOS packaged installers
should be copied to their appropriate package folders prior to
executing this script if they are to be included in this release
process, otherwise only the Linux files will be included.

Update linux packaging process
The 64bitBuild.sh script has been renamed to package.sh and has
been updated so that it is capable of performing the complete packaging
process without having to rely on the jar first being built and prepped
from the MacOS scripts. However, it does support having the jar
previously built and prepped and will look for a prepped jar in the
desktop/package folder. If not found, it will build and prep it
prior to packaging.

Additionally, the Bruntime option passed to javapackager is unnecessary and
has been removed. The Bruntime option is valid only when the -native
option is set to jnlp.

Also, the prepare-system.sh script was removed as it did not appear to be
doing anything useful.

Finally, a release.sh script has been added that will perform the
release process of copying necessary files to a versioned release folder
and generating/verifying signatures. Windows and MacOS packaged installers
should be copied to their appropriate package folders prior to
executing this script if they are to be included in this release
process, otherwise only the Linux files will be included.

@ManfredKarrer ManfredKarrer removed their request for review Jan 3, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Jan 3, 2019

@ripcurlx I leave the review to you.

@devinbileck devinbileck referenced this pull request Jan 4, 2019

Merged

Generate RPM package #2200

@ripcurlx
Copy link
Member

ripcurlx left a comment

@devinbileck Thanks for putting this PR together! I had a quick look over the changed scripts and I have following questions/remarks:

I want to prevent to create the release builds from source on every platform, as it is a time consuming process already and this would make it even slower. To be able to re-use an existing jar file it has to be placed in a similar structure as if I would have the full repository checked out. So we would also need to adapt

cp $EXE_JAR "$linux64/Bisq-$version.jar"
Correct? Could you add this changes as well, so my release process is still working with this PR?

The advantage of having the release process now also for Linux is that it is easier for Linux dev machines to create releases. The disadvantage is, that we have to maintain both release scripts if anything changes.

@devinbileck

This comment has been minimized.

Copy link
Member

devinbileck commented Jan 7, 2019

Correct. I can attempt to modify the macosx script. However, I think it requires a little more cleanup. I did not touch it because I am unable to test and verify any changes I make (no access to a Mac). But I agree about the duplication and perhaps the Linux and Mac build/prep portions can be combined into a single script, with only the packaging portion separated.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 7, 2019

@devinbileck No worries. I'll test it now on my VMs and will make the necessary changes.

ripcurlx added some commits Jan 7, 2019

Not override JAVA_HOME
Developer should configure this properly on its local machine before running the script

@ripcurlx ripcurlx merged commit 5553b3b into bisq-network:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:update-linux-packaging-process branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment