Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update linux packaging process #2190
The 64bitBuild.sh script has been renamed to package.sh and has
Additionally, the Bruntime option passed to javapackager is unnecessary and
Also, the prepare-system.sh script was removed as it did not appear to be
Finally, a release.sh script has been added that will perform the
left a comment
@devinbileck Thanks for putting this PR together! I had a quick look over the changed scripts and I have following questions/remarks:
I want to prevent to create the release builds from source on every platform, as it is a time consuming process already and this would make it even slower. To be able to re-use an existing jar file it has to be placed in a similar structure as if I would have the full repository checked out. So we would also need to adapt
The advantage of having the release process now also for Linux is that it is easier for Linux dev machines to create releases. The disadvantage is, that we have to maintain both release scripts if anything changes.
Correct. I can attempt to modify the macosx script. However, I think it requires a little more cleanup. I did not touch it because I am unable to test and verify any changes I make (no access to a Mac). But I agree about the duplication and perhaps the Linux and Mac build/prep portions can be combined into a single script, with only the packaging portion separated.