New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dao: fix late proposals processing #2191

Merged
merged 16 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Jan 3, 2019

No description provided.

ManfredKarrer added some commits Jan 1, 2019

Add peer address to error log
- Add full toString method to Connection.SharedModel
Fix handling of case when no seed node is available.
In regtest we got incorrectly onNoPeersAvailable called if the first
seed node in our list was not available. It triggered a
onAllServicesInitialized and led to incorrect behaviour in case we
received data from the second seednode. One bug was that we did not
clone the remaining nodes list in the for loop which led that the list
was empty for each delayed call. The other bug was that we did not
check if there is another connection attempt open when we got a
connection fault from the not available seed.
Change handling of addListeners and start calls
We add first all listeners at all services and then call the start methods.
Some services are listening on others so we need to make sure that the
listeners are set before we call start as that might trigger state change
which triggers listeners.

- Change order of ballotListService and proposalService to reflect
dependency.
Fix startup behaviour.
Call fillListFromProtectedStore and fillListFromAppendOnlyDataStore
at start. The listeners are not triggered as registered after we have
received the initial data. So we need to read the P2P network data at
the start method.

@ManfredKarrer ManfredKarrer requested a review from sqrrm Jan 3, 2019

@ManfredKarrer ManfredKarrer changed the title Dao fix late proposals processing Dao: fix late proposals processing Jan 3, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@sqrrm

sqrrm approved these changes Jan 4, 2019

Copy link
Member

sqrrm left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 39f3c6e into bisq-network:master Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:dao-fix-late-proposals-processing branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment