New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dao: Fix performance issue at parsing #2199

Merged
merged 6 commits into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Jan 3, 2019

No description provided.

ManfredKarrer added some commits Jan 3, 2019

Call onParseBlockComplete listeners only after onParseBlockChainComplete
To avoid performance issues we omit the listener calls at
onParseBlockComplete as long we are in the batch processing of blocks.
Without that optimization it took about 50 sec. for 4000 blocks, with it
we could reduce it to 4 seconds.

@ManfredKarrer ManfredKarrer requested a review from sqrrm Jan 3, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Jan 3, 2019

@sqrrm It is based on the other 2 PRs, you can ignore all before commit '2f9125a3db68200dcc1a97e9835f6050a6f07f85'.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 4, 2019

utACK - I'll add updating of the DAO and Testnet dbs to my release protocol.

@sqrrm

This comment has been minimized.

Copy link
Member

sqrrm commented Jan 5, 2019

utACK

@ManfredKarrer ManfredKarrer merged commit a41b4a5 into bisq-network:master Jan 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:dao-fix-performance-issue-at-parsing branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment