New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offer button state on account change #2205

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@j3ko
Copy link
Member

j3ko commented Jan 4, 2019

fixes #2204

Add updateButtonDisabledState() to onPaymentAccountSelected() in
TakeOfferViewModel since changing the account dropdown in the take
offer screen does not trigger an update of the "Next Step" button.

The default amount of an offer should not change to less than what is
actually offered, change onPaymentAccountSelected() in
TakeOfferDataModel to take into account the min. amount offered.

In TakeOfferView, the payment account defaults to the last one
selected. Make sure TakeOfferViewModel and TakeOfferDataModel take
this into account in a couple locations.

Update offer button state on account change
Add updateButtonDisabledState() to onPaymentAccountSelected() in
TakeOfferViewModel since changing the account dropdown in the take
offer screen does not trigger an update of the "Next Step" button.

The default amount of an offer should not change to less than what is
actually offered, change onPaymentAccountSelected() in
TakeOfferDataModel to take into account the min. amount offered.

In TakeOfferView, the payment account defaults to the last one
selected.  Make sure TakeOfferViewModel and TakeOfferDataModel take
this into account in a couple locations.

@j3ko j3ko requested review from ManfredKarrer and ripcurlx as code owners Jan 4, 2019

@ManfredKarrer ManfredKarrer removed their request for review Jan 6, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 7, 2019

ACK - @j3ko Thanks for the PR!

@ripcurlx ripcurlx merged commit 75e9e99 into bisq-network:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment