New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations for http api #2207

Merged
merged 6 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Jan 6, 2019

This contains non-critical code changes for preparing the http-api branch merge. The more complex code changes will come in separate PRs later....

ManfredKarrer added some commits Jan 6, 2019

Add null check at getMyTradeLimit
Other small changes:
- Remove final from User as http-api branch will require to extend it.
- Add comment

@ManfredKarrer ManfredKarrer requested review from ripcurlx , blabno and sqrrm Jan 6, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@blabno

blabno approved these changes Jan 7, 2019

Copy link
Contributor

blabno left a comment

ACK

@ManfredKarrer ManfredKarrer merged commit d5a53e9 into bisq-network:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:preparations-for-http-api branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment