New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default system JDK #2211

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

devinbileck commented Jan 7, 2019

The install_java.sh script was not setting the appropriate java and
javac as default. This is not an issue if no other JDK is installed, but
if so it could cause the wrong JDK to be used. So it now sets the
appropriate default system JDK.

Also, added a comment at the top of the install_java.sh and
install_java.bat files indicating it configures the default system
JDK and informs the user how to go about selecting a different
default JDK if necessary.

Configure default system JDK
The install_java.sh script was not setting the appropriate java and
javac as default. This is not an issue if no other JDK is installed, but
if so it could cause the wrong JDK to be used. So it now sets the
appropriate default system JDK.

Also, added a comment at the top of the install_java.sh and
install_java.bat files indicating it configures the default system
JDK and informs the user how to go about selecting a different
default JDK if necessary.

@devinbileck devinbileck requested a review from ManfredKarrer as a code owner Jan 7, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 3c8bdaf into bisq-network:master Jan 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@devinbileck devinbileck deleted the devinbileck:configure-default-system-jdk branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment