New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce maker fee #2213

Merged
merged 5 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Jan 7, 2019

ManfredKarrer added some commits Jan 7, 2019

Apply code inspection
- Add null and isPresent checks
Reduce maker fee, increase take fee
- Reduce maker fee to 0,1%, increase take fee to 0,3%

As approved by proposal
bisq-network/proposals#65
@ripcurlx
Copy link
Member

ripcurlx left a comment

Please fix CreateOfferViewModelTest.java:115. Besides that utACK

ManfredKarrer added some commits Jan 7, 2019

@ManfredKarrer ManfredKarrer merged commit 0112c2e into bisq-network:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:reduce-maker-fee branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment