Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows install custom translations #2247

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

devinbileck commented Jan 11, 2019

The Bisq.iss file must be saved using UTF-8 encoding with BOM for the unicode custom messages to be displayed properly.

For example, the v0.9.3 release on Windows 7 French has the following issues:

  • Launching the installer with the application running shows the following incorrect message text:
    image

  • Observing the application within the control panel shows the following incorrect message text:
    image

Note, this issue only affects the custom messages contained within the Bisq.iss file, not the general translations within the installer.

Fix windows install custom translations
The Bisq.iss file must be saved using UTF-8 encoding with BOM for the
unicode custom messages to be displayed properly.
@devinbileck

This comment has been minimized.

Copy link
Member Author

devinbileck commented Jan 11, 2019

@ripcurlx let me know if you are still encountering issues with the BOM.

@ripcurlx ripcurlx self-assigned this Jan 14, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 14, 2019

I'll check it out again, but I fear it will fail during the build again. I'll let you know about the outcome

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 14, 2019

@devinbileck Unfortunately I always get following error (Windows 10 Home):

Error on line 1 in C:\Users\chris\AppData\Local\Temp\fxbundler2867454632442430686\images\win-exe.image\Bisq.iss: Text is not inside a section.
Compile aborted.
java.io.IOException: Exec failed with code 2 command [[C:\Program Files (x86)\Inno Setup 5\iscc.exe, /oE:\desktop\package\windows\..\windows, C:\Users\chris\AppData\Local\Temp\fxbundler2867454632442430686\images\win-exe.image\Bisq.iss] in C:\Users\chris\AppData\Local\Temp\fxbundler2867454632442430686\images\win-exe.image

If I run the Bisq.iss file within the Inno Setup Compiler I get following error:
screenshot

Any idea why it fails on my side?

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 14, 2019

ACK - I searched quickly around and found out, that the problem is the non-unicode installation of InnoSetup. I now installed a unicode version manually and it builds now without any problem.

@ripcurlx ripcurlx merged commit 2fe5092 into bisq-network:master Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-windows-install-custom-translations branch Jan 14, 2019

@devinbileck devinbileck referenced this pull request Jan 31, 2019

Closed

For January 2019 #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.