Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installer background image #2265

Merged
merged 3 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

ripcurlx commented Jan 14, 2019

Fixes #2262.

ripcurlx added some commits Jan 14, 2019

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Jan 14, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK -> NACK overlooked that version must not include snapshot

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

NACK

@@ -27,7 +27,7 @@
// VERSION = 0.5.0 introduces proto buffer for the P2P network and local DB and is a not backward compatible update
// Therefore all sub versions start again with 1
// We use semantic versioning with major, minor and patch
public static final String VERSION = "0.9.3";
public static final String VERSION = "0.9.3-SNAPSHOT";

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Jan 14, 2019

Member

Ups I was too fast with ACK. That must not include the snapshot postfix!

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Jan 14, 2019

Did the change myself, so not its utACk again and I merge it ;-)

@ManfredKarrer ManfredKarrer merged commit 7b2d00f into bisq-network:master Jan 14, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ripcurlx ripcurlx referenced this pull request Feb 27, 2019

Closed

For February 2019 #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.