Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trade currency handling for multiple currency payment accounts #2310

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

ripcurlx commented Jan 23, 2019

Fixes #1753.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Jan 23, 2019

@ripcurlx ripcurlx changed the title Fix trade currency handling for multiple currency payment accounts [WIP] Fix trade currency handling for multiple currency payment accounts Jan 23, 2019

ripcurlx added some commits Jan 23, 2019

Bind currency combobox to trade currency from model
Remove data logic from view model that is set in data model

@ripcurlx ripcurlx force-pushed the ripcurlx:fix-tradecurrency-selection branch from 9fe4aff to 0a7c85f Jan 23, 2019

@ripcurlx ripcurlx changed the title [WIP] Fix trade currency handling for multiple currency payment accounts Fix trade currency handling for multiple currency payment accounts Jan 23, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

ACK

@ManfredKarrer ManfredKarrer merged commit 83d67e3 into bisq-network:master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Feb 27, 2019

Closed

For February 2019 #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.