Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow host as bitcoinRegtestHost parameter #2312

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@devinbileck
Copy link
Member

devinbileck commented Jan 23, 2019

When using a remote regtest host, instead of having to pass
REG_TEST_SERVER to the bitcoinRegtestHost parameter and hard code the
host address within the code, allow the host to be specified by the
bitcoinRegtestHost parameter.

Allow host as bitcoinRegtestHost parameter
When using a remote regtest host, instead of having to pass
REG_TEST_SERVER to the bitcoinRegtestHost parameter and hard code the
host address within the code, allow the host to be specified by the
bitcoinRegtestHost parameter.

@devinbileck devinbileck requested a review from ManfredKarrer as a code owner Jan 23, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Jan 23, 2019

@devinbileck Can you merge in master? There have been some issue with a test class

@devinbileck

This comment has been minimized.

Copy link
Member Author

devinbileck commented Jan 23, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK - But as I haven't touched part of this code yet, I'll leave it to @ManfredKarrer to merge.

@ripcurlx ripcurlx added the re:Bitcoin label Jan 24, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 92d15c2 into bisq-network:master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:regtest-host-parameter branch Jan 24, 2019

@ripcurlx ripcurlx referenced this pull request Jan 30, 2019

Closed

For January 2019 #206

@devinbileck devinbileck referenced this pull request Jan 31, 2019

Closed

For January 2019 #215

@devinbileck devinbileck referenced this pull request Feb 25, 2019

Closed

For February 2019 #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.