Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tor files at startup #2344

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Jan 30, 2019

We get sometimes Tor startup problems which is related to some tor
files in the tor directory. It happens more often if the application
got killed (not graceful shutdown).
Creating all tor files newly takes about 3-4 sec. longer and it does
not benefit from cache files.
TODO: We should fix those startup problems in the netlayer library,
once fixed there we can remove that call at the
Bisq startup again.

Delete tor files at startup
We get sometimes Tor startup problems which is related to some tor
files in the tor directory. It happens more often if the application
got killed (not graceful shutdown).
Creating all tor files newly takes about 3-4 sec. longer and it does
not benefit from cache files.
TODO: We should fix those startup problems in the netlayer library,
once fixed there we can remove that call at the
Bisq startup again.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner Jan 30, 2019

@ManfredKarrer ManfredKarrer requested a review from freimair Jan 30, 2019

@ripcurlx ripcurlx assigned freimair and unassigned freimair Jan 30, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@freimair
Copy link
Member

freimair left a comment

utAck

@ripcurlx ripcurlx merged commit 51bf21e into bisq-network:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:clean-up-tor-files-at-startup branch Jan 30, 2019

@HarryMacfinned

This comment has been minimized.

Copy link

HarryMacfinned commented Jan 30, 2019

We just got one more Tor issue on the forum.

I wonder if there are not some companies working for govs, who use IPs addresses, do voluntarily bad things with those IPs over the Tor network, in order to have those IPs banned.
And so we have more and more IPs unusable.
... but maybe I'm paranoid.

@freimair freimair referenced this pull request Feb 28, 2019

Closed

For February 2019 #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.