Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tor to be used with regtest #2346

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@devinbileck
Copy link
Member

devinbileck commented Jan 30, 2019

In order to simulate a realistic environment for testing purposes, this will allow tor to be used with regtest. Use the bitcoinRegtestHost parameter and specify a tor .onion address as well as include the --useTorForBtc=true parameter.

devinbileck added some commits Jan 30, 2019

Allow tor to be used on regtest
This allows for a tor .onion address to be specified as the
bitcoinRegtestHost parameter and, as long as the --useTorForBtc=true
parameter is included, it will use tor when on regtest.
Update logging indicating number of btc nodes
The logged message that indicates the number of btc nodes to connect to
was incorrect when only a single node is used in regtest mode.

@devinbileck devinbileck requested a review from ManfredKarrer as a code owner Jan 30, 2019

@devinbileck devinbileck referenced this pull request Jan 31, 2019

Closed

For January 2019 #215

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Feb 2, 2019

@devinbileck In case you have not seen my comments, could you have a look?

@devinbileck

This comment has been minimized.

Copy link
Member Author

devinbileck commented Feb 3, 2019

@ManfredKarrer I dont see any comments within this PR.

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 68a6de2 into bisq-network:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:tor-on-regtest branch Feb 4, 2019

@devinbileck devinbileck referenced this pull request Feb 25, 2019

Closed

For February 2019 #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.