Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor release: Showing off #2348

Merged
merged 40 commits into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@freimair
Copy link
Member

freimair commented Jan 31, 2019

see bisq-network/proposals#62 for details

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

In P2PNetworkLoad.java:

Why not use
buckets.putIfAbsent(className, new Counter()); buckets.get(className).increment();

instead of
try { buckets.get(className).increment(); } catch (NullPointerException nullPointerException) { buckets.put(className, new Counter()); }

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Feb 1, 2019

In P2PNetworkLoad.java:
Re:
bucketsPerHost.put(connection.peersNodeAddressProperty().getValue(), buckets);
It can be that connection.peersNodeAddressProperty() is not set yet. Maybe more safe if you add a check if it is nul null.

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 159a5e5 into bisq-network:master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019

Closed

For February 2019 #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.