Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dao: Add handler for republishing all dao governance data, improve vote result handling #2363

Merged
merged 13 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Feb 3, 2019

No description provided.

ManfredKarrer added some commits Feb 2, 2019

Add PermutationUtil
In case that the users blind vote list does not match the hash of the
majority we want to find if any variation of our list leads to a match
so we can still calculate the vote result.
Merge branch 'dao-permute-blindvotelist-if-not-majority-hash' into da…
…o-fix-vote-result-with-permutated-blindvotelist

# Conflicts:
#	core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java
Fix republish checks
Remove parsingComplete check

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner Feb 3, 2019

@ManfredKarrer ManfredKarrer requested a review from sqrrm Feb 3, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member Author

ManfredKarrer commented Feb 3, 2019

@sqrrm I will rebase after i merged master with the other 2 PRs...

@ManfredKarrer ManfredKarrer changed the title Dao: add resets all data handler, improve vote result handling Dao: add handler for republishing all dao governancen data, improve vote result handling Feb 3, 2019

@ManfredKarrer ManfredKarrer changed the title Dao: add handler for republishing all dao governancen data, improve vote result handling Dao: Add handler for republishing all dao governance data, improve vote result handling Feb 3, 2019

@sqrrm

sqrrm approved these changes Feb 3, 2019

Copy link
Member

sqrrm left a comment

utACK

The comments on log level stand but it's just refactoring so can be tended to in another PR

boolean success = p2PService.addPersistableNetworkPayload(proposalPayload, true);
String txId = proposalPayload.getProposal().getTxId();
if (success) {
log.warn("We received a RepublishGovernanceDataRequest and re-published a proposalPayload to " +

This comment has been minimized.

@sqrrm

sqrrm Feb 3, 2019

Member

Maybe this shouldn't be warning level log

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Feb 3, 2019

Author Member

Yes was also wondering. But it make it more visible if that occurres so that anyone can see if any peer is missing data. Basically the P2P network should be reliable enough to not cause that.

boolean success = p2PService.addPersistableNetworkPayload(blindVotePayload, true);
String txId = blindVotePayload.getBlindVote().getTxId();
if (success) {
log.warn("We received a RepublishGovernanceDataRequest and re-published a blindVotePayload to " +

This comment has been minimized.

@sqrrm

sqrrm Feb 3, 2019

Member

Same here, I don't think warning level is right

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Feb 3, 2019

Author Member

Ah, I see now, its at each success case, thats definitely too much. Will fix it in next PR.

@ManfredKarrer ManfredKarrer merged commit 7741134 into bisq-network:master Feb 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:dao-fix-vote-result-with-permutated-blindvotelist branch Feb 3, 2019

@sqrrm sqrrm referenced this pull request Feb 28, 2019

Closed

For February 2019 #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.