Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing removal of old or invalid proposals #2377

Merged
merged 2 commits into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Feb 5, 2019

  • If a proposal had a tx which is not in our BSQ state it was not removed
  • If a tx was outdated (> 60 days old) it was only removed if we are
    in proposal phase. We added check for past cycle to cover those as well.
Fix missing removal of old or invalid proposals
- If a proposal had a tx which is not in our BSQ state it was not removed
- If a tx was outdated (> 60 days old) it was only removed if we are
in proposal phase. We added check for past cycle to cover those as well.

@ManfredKarrer ManfredKarrer requested a review from sqrrm Feb 5, 2019

@ripcurlx ripcurlx added the in:dao label Feb 6, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

@ManfredKarrer

This comment has been minimized.

Copy link
Member Author

ManfredKarrer commented Feb 6, 2019

@sqrrm Could u have a look as well?

@sqrrm

sqrrm approved these changes Feb 10, 2019

Copy link
Member

sqrrm left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit f87522f into bisq-network:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:dao-fix-remove-proposal-handling branch Feb 14, 2019

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019

Closed

For February 2019 #224

@sqrrm sqrrm referenced this pull request Feb 28, 2019

Closed

For February 2019 #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.