Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until proposal is published before resetting the form #2384

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

ripcurlx commented Feb 7, 2019

Fixes #2367.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Feb 7, 2019

@ripcurlx ripcurlx added the in:dao label Feb 7, 2019

@ManfredKarrer ManfredKarrer requested a review from sqrrm Feb 9, 2019

@sqrrm
Copy link
Member

sqrrm left a comment

See comment on animation on error. Apart from that it looks good.

errorMessage -> new Popup<>().warning(errorMessage).show());
errorMessage -> {
new Popup<>().warning(errorMessage).show();
makeProposalButton.setDisable(false);

This comment has been minimized.

@sqrrm

sqrrm Feb 10, 2019

Member

By not disabling the busyAnimation/button here it will keep spinning after an error was reported, I don't think that's correct.

This comment has been minimized.

@ripcurlx

ripcurlx Feb 11, 2019

Author Member

Yes, it also should be reset in case of an error. Just pushed the commit.

@ripcurlx ripcurlx force-pushed the ripcurlx:wait-for-proposal-confirmation branch from 5aae5fb to dfeb6b0 Feb 11, 2019

@ripcurlx ripcurlx merged commit 4c10620 into bisq-network:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019

Closed

For February 2019 #224

@sqrrm sqrrm referenced this pull request Feb 28, 2019

Closed

For February 2019 #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.