Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List DSTRA (DST) #2385

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@krestien
Copy link
Contributor

commented Feb 7, 2019

@blabno
Copy link
Contributor

left a comment

NACK per comments.

Also please squash those commits into a single one.


@Test
public void testInvalidAddresses() {
assertInvalidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd77");

This comment has been minimized.

Copy link
@blabno

blabno Feb 18, 2019

Contributor

Please format the code according to Bisq code style.

This comment has been minimized.

Copy link
@krestien

krestien Feb 18, 2019

Author Contributor

Hi @blabno and thank you for checking my PR!
After review I simply can't find the spot where I violated Bisq code style. I took a look at several examples (PIVXTest, ZcashTest, etc.) and it seems to me like my file is exactly looking the same.
Maybe you can guide me to what's wrong with my Test class. Only style reference for bisq I found is https://github.com/bisq-network/style and it doesn't contain anything regarding code style as far as I could see as it's pretty new.

This comment has been minimized.

Copy link
@blabno

blabno Feb 18, 2019

Contributor

Lines 38-40 are not aligned.

This comment has been minimized.

Copy link
@krestien

krestien Feb 18, 2019

Author Contributor

Tried to fix it with IDEA (did the code with Notepad++ before) and I hope it's done now @blabno .
I can't see other alignment issues.
Squashed again, hoping for an ACK this time

Show resolved Hide resolved assets/src/test/java/bisq/asset/coins/DSTRATest.java Outdated

@krestien krestien force-pushed the DSTRACoin:list-dstra-asset branch from 63ec821 to 9eb7061 Feb 18, 2019

@krestien

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

NACK per comments.

Also please squash those commits into a single one.

Resolved what I was able to and squashed commits, hoping for an ACK

@krestien krestien force-pushed the DSTRACoin:list-dstra-asset branch from 022e292 to 85971f8 Feb 18, 2019

@blabno

blabno approved these changes Mar 4, 2019

Copy link
Contributor

left a comment

ACK

@ripcurlx ripcurlx merged commit 3e767fa into bisq-network:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.