Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indication that BSQ transactions are not up to date #2388

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

ripcurlx commented Feb 7, 2019

Fixes #2303.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Feb 7, 2019

@ripcurlx ripcurlx added the in:dao label Feb 8, 2019

@sqrrm

sqrrm approved these changes Feb 10, 2019

Copy link
Member

sqrrm left a comment

ACK

I have tested and it works, but I still think it would be better with a separate service for the sync handling to not pollute the setup class.

/**
* High level entry point for Dao domain.
* We initialize all main service classes here to be sure they are started.
*/
public class DaoSetup {
public class DaoSetup implements DaoStateListener {

This comment has been minimized.

@sqrrm

sqrrm Feb 10, 2019

Member

I think it would be better to make a separate BSQSyncService or something like that, it feels wrong to add this to the DaoSetup.

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Feb 11, 2019

Member

I would prefer to not use DaoSetup for that but DaoFacade (or some custom class). I will have a look soon into it to make a more concrete sugestion.

This comment has been minimized.

@ManfredKarrer

This comment has been minimized.

@ripcurlx

ripcurlx Feb 11, 2019

Author Member

Yes, I also wasn't quite happy to put it in this place, I just though to make it consistent how it is handled with the btcInfo WalletSetup right now:

// Wallet
public StringProperty getBtcInfo() {
return walletAppSetup.getBtcInfo();
}
public DoubleProperty getBtcSyncProgress() {
return walletAppSetup.getBtcSyncProgress();
}

private final StringProperty btcInfo = new SimpleStringProperty(Res.get("mainView.footer.btcInfo.initializing"));

How do we differentiation between a Facade and a Service atm in Bisq?
I'll have a look to find a better place for this presentation logic. I might change the implementation of the btcInfo/btcSyncProgress on the way as well.

This comment has been minimized.

@ripcurlx

ripcurlx Feb 11, 2019

Author Member

I moved the code into the DaoPresentation class which I created already for another DAO related PR.

@ripcurlx ripcurlx force-pushed the ripcurlx:add-indication-for-unparsed-bsq-transactions branch from 8579fbd to d6b1863 Feb 11, 2019

@ripcurlx ripcurlx force-pushed the ripcurlx:add-indication-for-unparsed-bsq-transactions branch from d6b1863 to 6bea5da Feb 11, 2019

@ripcurlx ripcurlx merged commit 14d5330 into bisq-network:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019

Closed

For February 2019 #224

@sqrrm sqrrm referenced this pull request Feb 28, 2019

Closed

For February 2019 #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.