Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt DAO news view for Mainnet #2421

Merged
merged 3 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

ripcurlx commented Feb 14, 2019

Fixes #2349.
@pedromvpg I tried to match your design as close as possible. I had to use a news tab to prevent a bigger rewrite of the DAO view navigation concept and add a external link indicator to the links which we use throughout the app. Still I changed it to a material design link icon which looks better IMHO.

bildschirmfoto 2019-02-14 um 15 02 53

ripcurlx added some commits Feb 13, 2019

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Feb 14, 2019

@ripcurlx ripcurlx force-pushed the ripcurlx:adapt-dao-teaser-page branch from 42051b5 to 12ea718 Feb 14, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 892f549 into bisq-network:master Feb 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pedromvpg

This comment has been minimized.

Copy link
Member

pedromvpg commented Feb 15, 2019

Cool

Just a couple of comments (ignore if not possible):

  • Remove subnav (News btn)
  • Increase padding overall, currently too close to the edge of the window
  • Make the background white

@ripcurlx ripcurlx referenced this pull request Feb 27, 2019

Closed

For February 2019 #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.