Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct and complete Monero and Cryptonote address validator #2422

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@xiphon
Copy link
Contributor

xiphon commented Feb 15, 2019

Fixes #1652

The code is consistent with Monero codebase.
Implements address decoding, checksum validation, prefix matching.

Supports all the other Cryptonote coins as well.

PS:
Skips Cash2 checksum validation (the coin uses BLAKE2b instead of Keccak1600), but there are still plenty of other checks out there.

@xiphon xiphon force-pushed the xiphon:monero-validator branch 6 times, most recently from f0ce7aa to 75293fb Feb 15, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

ACK

Great thanks!!!!

@ManfredKarrer

This comment has been minimized.

Copy link
Member

ManfredKarrer commented Feb 15, 2019

@ManfredKarrer ManfredKarrer merged commit 75293fb into bisq-network:master Feb 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xiphon xiphon referenced this pull request Feb 28, 2019

Closed

For February 2019 #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.