Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more instructions at dispute system message #2428

Merged
merged 3 commits into from Feb 17, 2019

Conversation

Projects
None yet
4 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Feb 16, 2019

  • Use redirect link for arbitr. doc

Again: Apologize late PR. Its uncritical but if problem feel free to keep for next release.

Add more instructions at dispute system message
- Use redirect link for arbitr. doc

@ManfredKarrer ManfredKarrer requested a review from ripcurlx Feb 16, 2019

@devinbileck
Copy link
Member

devinbileck left a comment

Nit
Mostly just some grammatical issues. I noticed there may be a few other phrases that could be reworked as well, but I think @m52go might be better suited to do that than myself.

Show resolved Hide resolved desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java Outdated
Show resolved Hide resolved core/src/main/resources/i18n/displayStrings.properties Outdated
Show resolved Hide resolved core/src/main/resources/i18n/displayStrings.properties Outdated
Show resolved Hide resolved core/src/main/resources/i18n/displayStrings.properties Outdated
Show resolved Hide resolved core/src/main/resources/i18n/displayStrings.properties Outdated
Show resolved Hide resolved core/src/main/resources/i18n/displayStrings.properties Outdated
\t● You need to respond to the arbitrator's requests within 2 days.\n\
\t● The maximum period for a dispute is 14 days.\n\
\t● You need to cooperate with the arbitrator and provide the information they request to make your case.\n\
\t● You accepted the rules outlined in the dispute document in the user agreement when you first started the application.\n\n\

This comment has been minimized.

@devinbileck

devinbileck Feb 16, 2019

Member

Should this be a bullet item? Or part of the sentence above?

Please make yourself familiar with the basic rules for the dispute process. You accepted the rules outlined in the dispute document in the user agreement when you first started the application.

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Feb 17, 2019

Author Member

Which one you mean? The
"You accepted the rules"?

This comment has been minimized.

@devinbileck

This comment has been minimized.

@ManfredKarrer

ManfredKarrer Feb 17, 2019

Author Member

Was intended to be a bullet point

m52go added a commit to bisq-network/bisq-docs that referenced this pull request Feb 16, 2019

Fix typo in headline
Typo should be banished ASAP no matter what, but this is potentially needed for bisq-network/bisq#2428.

@m52go m52go referenced this pull request Feb 16, 2019

Merged

Fix typo in headline #109

@ripcurlx
Copy link
Member

ripcurlx left a comment

utACK

ManfredKarrer added some commits Feb 17, 2019

@ManfredKarrer ManfredKarrer merged commit edb050a into bisq-network:master Feb 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:add-more-info-at-dispute-system-msg branch Feb 17, 2019

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019

Closed

For February 2019 #224

@devinbileck devinbileck referenced this pull request Feb 27, 2019

Closed

For February 2019 #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.