Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak in message throttle mechanism #2475

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@freimair
Copy link
Member

freimair commented Feb 27, 2019

mostly showed during seed node operations (as the seed nodes tend to run for longer than a client), however, every Bisq instance has been affected.

Made a test with MSG_THROTTLE_PER_10_SEC = 50:

_ diff byte[] in 15min
before +700.000
after: +100

fixes #599 - finally (and hopefully)

@freimair freimair requested a review from ManfredKarrer as a code owner Feb 27, 2019

@ManfredKarrer
Copy link
Member

ManfredKarrer left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 76e406a into bisq-network:master Feb 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freimair freimair deleted the freimair:memoryleak_be_gone branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.