Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow spending of unconfirmed BSQ change outputs #2482
When creating a BSQ transaction (actually at commit time as we can create a tx and then
We update out list at each new block confirmation.
With that approach we avoid too much dependencies to the BitcoinJ side.
sqrrm left a comment
I think this is a better way to handle it than through the parser. I tried using the parser and that's just too risky and hard to control in the end, this way is much more controlled and only very specifically designated change outputs can be spent without confirmation and parsing which is safer.
The problem would be that this is more fragile if we start changing anything in the BSQ parsing as this is now a separate kind of parsing that needs to be handled with great care.
ripcurlx left a comment
NACK - Besides the validation problems mentioned below for going over your available balance it looks fine.